feat(t101): electron notification channel mutes#13
Merged
Conversation
Dokploy Preview Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Electron app gains per-source notification mute channels at parity with the PWA — silence a noisy service (Teams/Outlook) or a Slack workspace so it stops firing the OS notification, the dock badge, and the sidebar unread counts, while still listing (dimmed) in the Inbox.
Spec:
docs/tasks/done/101-electron-notification-channel-mutes.md.How
caps.web ? bigCard : smallCardsplit insettings-dialog.tsxcollapses into ONE Notifications card used by both builds. Master + the mute list ([...ADAPTER_MUTE_ROWS, ...slackRows]) render identically; only the push row (web-only) and the Slack-row source differ inline.core/notifications.jsshouldNotifyOsgains amutesparam (gates viacore/notif-mutes.jsisMuted);main.jspassessettings.notifMutesand mute-excludes the dock badge viaunreadExcluding.core/settings-store.jsmakesnotifMutesa settable global (Electron is single-device; web still uses the device-keyednotifMutes_<deviceId>slot — the transport deletes the plain key before POST, so the global never leaks on web).src/lib/notif-mutes.tsaddsslackMuteRows(notifications)— derives per-workspace mute rows from captured hijack entries (label = the workspace name the entry carries insource), the Electron mute-list source since it has no sweep/health.src/app.tsxungates the mute-aware badges (muteOpts/unreadExcluding) for both builds;toolbar.tsxforwards anotificationsprop.Web rendering is unchanged by construction (same components + adapters-then-Slack row order).
Housekeeping
Also closes two shipped-but-open task files (t096, t098 →
done/; both shipped in PR #10 /f0a456a).Tests
typecheck · 1024 unit (+
shouldNotifyOsmutes ×4,slackMuteRows×5, settings-store ×1) · 49 e2e · build ·node --checkmain.js + server.mjs · Biome clean. The Electron mute UI + dock-badge + persist-across-restart smoke is verified on the packaged app (pnpm install:local).https://claude.ai/code/session_01USyifc9ZK6Cy5hAmKKy2ok