Skip to content

Disable CA Pinning: Add constructor parameter #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cisco-annikiti merged 2 commits into from
Jul 16, 2026
Merged

Disable CA Pinning: Add constructor parameter #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
078aa0f
Disable CA Pinning: Add constructor parameter
cisco-annikiti Jul 14, 2026
e871e93
Explicitly enforce TLS verification to override NODE_TLS_REJECT_UNAUT…
cisco-annikiti Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ const _PACKAGE_VERSION = require('../package.json').version
const SIGNATURE_VERSION_2 = 2
const SIGNATURE_VERSION_5 = 5

function Client (ikey, skey, host, sigVersion = SIGNATURE_VERSION_2) {
function Client (ikey, skey, host, sigVersion = SIGNATURE_VERSION_2, enableCAPinning = true) {
this.ikey = ikey
this.skey = skey
this.host = host
this.sigVersion = sigVersion
this.enableCAPinning = enableCAPinning
}

Client.prototype.apiCall = function (method, path, params, callback) {
Expand Down Expand Up @@ -53,7 +54,10 @@ Client.prototype.apiCall = function (method, path, params, callback) {
'method': method,
'path': path,
'headers': headers,
'ca': constants.DUO_PINNED_CERT
'rejectUnauthorized': true
}
if (this.enableCAPinning) {
Comment thread
cisco-annikiti marked this conversation as resolved.
options.ca = constants.DUO_PINNED_CERT
}
_request_with_backoff(options, body, callback)
}
Expand Down
46 changes: 46 additions & 0 deletions tests/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
var assert = require('assert')
var nock = require('nock')
var sinon = require('sinon')
var https = require('https')
var duo_api = require('../lib/main.js')
var duo_sig = require('../lib/duo_sig')
var constants = require('../lib/constants')

var IKEY = 'DIXXXXXXXXXXXXXXXXXX'
var SKEY = 'deadbeefdeadbeefdeadbeefdeadbeefdeadbeef'
Expand Down Expand Up @@ -189,3 +191,47 @@ describe('Signature Checks', function () {
})
})
})

describe('CA Pinning Configuration', function () {
var requestSpy

beforeEach(function () {
requestSpy = sinon.spy(https, 'request')
nock('https://' + API_HOSTNAME)
.get('/foo/bar')
.reply(200, {'response': {foo: 'bar'}, stat: 'OK'})
})

afterEach(function () {
requestSpy.restore()
})

it('CA pinning is enabled by default', function (done) {
var client = new duo_api.Client(IKEY, SKEY, API_HOSTNAME)
assert.strictEqual(client.enableCAPinning, true)
client.jsonApiCall('GET', '/foo/bar', {}, function (resp) {
var options = requestSpy.firstCall.args[0]
assert.strictEqual(options.ca, constants.DUO_PINNED_CERT)
done()
})
})

it('CA pinning can be disabled via constructor parameter', function (done) {
var client = new duo_api.Client(IKEY, SKEY, API_HOSTNAME, duo_api.SIGNATURE_VERSION_2, false)
assert.strictEqual(client.enableCAPinning, false)
client.jsonApiCall('GET', '/foo/bar', {}, function (resp) {
var options = requestSpy.firstCall.args[0]
assert.strictEqual(options.ca, undefined)
done()
})
})

it('TLS verification is still enforced when CA pinning is disabled', function (done) {
var client = new duo_api.Client(IKEY, SKEY, API_HOSTNAME, duo_api.SIGNATURE_VERSION_2, false)
client.jsonApiCall('GET', '/foo/bar', {}, function (resp) {
var options = requestSpy.firstCall.args[0]
assert.strictEqual(options.rejectUnauthorized, true)
done()
})
})
})
Loading