Add CA bundle version and pinning status to the user agent string#46
Merged
Conversation
cisco-dmytro-hissa
marked this pull request as ready for review
July 16, 2026 14:12
brandonwongduo
requested changes
Jul 20, 2026
brandonwongduo
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CA_BUNDLE_VERSION = '1.0'constant.user_agenthelper that builds the string from runtime state, reading@ca_pinning_disabledto reflect the actual pinning state."duo_api_ruby/#{VERSION}"header with a call touser_agent.How Has This Been Tested?
TestUserAgent— verifies the composed string for both pinning states and that the CA bundle version is present.TestUserAgentHeader— verifies the actual User-Agent header sent on a request for both a pinned and unpinned client.Types of Changes