fix: use tenant-specific JWKS endpoint#441
Merged
Merged
Conversation
Cullima
approved these changes
Jul 1, 2026
andrewsetterfield
approved these changes
Jul 1, 2026
There was a problem hiding this comment.
Pull request overview
Updates JWT verification in @dvsa/appdev-api-common to resolve Microsoft Azure AD JWKS endpoints per tenant, instead of always using the common endpoint, and adds unit tests for tenant-specific vs fallback behavior.
Changes:
- Derive the JWKS endpoint from the configured tenant ID (fallback to
commonwhen absent). - Cache a
createRemoteJWKSetinstance per tenant to avoid rebuilding fetchers. - Add Jest unit tests for tenant-specific and fallback JWKS resolution; bump package patch version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/appdev-common/src/auth/verify-jwt.ts | Adds tenant-derived JWKS URL selection and per-tenant caching for remote JWK sets. |
| packages/appdev-common/src/auth/tests/verify-jwt.spec.ts | Adds unit tests for tenant-specific vs common JWKS URL selection. |
| packages/appdev-common/package.json | Bumps package version to 2.0.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Looks fine but you'll need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary