Refactor clone_field method implementation#60
Open
Izcarmt95 wants to merge 2 commits into
Open
Conversation
Refactor clone_field method to use _copy and set attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
clone_fieldmethod to use_copyand explicitly set attributes.The previous implementation generated an incorrect annotation (
annotation=PlainReprinstead ofannotation=NoneType). This resulted in an invalid JSON schema and incorrect foreign key (FK) validation.This occured when you put an FK as optional field
you can see this test in
categoryattribute:ninja-schema/tests/test_v2_pydantic/test_model_schema.py
Line 39 in f6bc331
ninja-schema/tests/test_v2_pydantic/test_model_schema.py
Line 230 in f6bc331