fix(cli): narrow tsconfig include so cli typecheck skips electron modules#12
Merged
Conversation
…ules The cli/tsconfig.json previously globbed `../src/main/**`, which dragged electron- and `which`-dependent files into the cli typecheck. The cli CI step had no node_modules for those, so it failed after PR #11 merged. The cli only needs: - src/main/{providers,gateways,wiring,fsutil} — no electron - src/shared/{index,channels,types} Switched to an explicit include list and dropped the bun-types fallback. `bun run cli → bun build --compile` still passes, runtime unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI's CI step failed after #11 merged because
cli/tsconfig.jsonglobbed../src/main/**, which dragged electron-dependent (safeStorage,ipcMain) andwhich-dependent modules into the CLI's typecheck. CLI has noelectrondependency installed.Fix
Switched
cli/tsconfig.jsonto an explicit include list of only the leaf files CLI modules actually reach —src/main/{providers,gateways,wiring,fsutil}andsrc/shared/*. None of those import electron, so they typecheck cleanly under just@types/node.Verification
bun run cli → bun build --compile✓./dist/hoist liststill prints harnesses + providers + gatewaysnpm run typecheck && npm run lint && npm run build) still ✓