Add QNX logging wrapper and update SlogCode/SlogSeverity enums by Muhammad-Hussein-Morsy · Pull Request #344 · eclipse-score/baselibs

Muhammad-Hussein-Morsy · 2026-07-06T10:21:35Z

No description provided.

github-actions · 2026-07-06T10:30:24Z

The created documentation from the pull request is available at: docu-html

ravindra181 · 2026-07-07T09:18:03Z

+/// @param format Printf-style format string
+/// @param ... Format arguments
+/// @return The number of bytes written on success, or an Error on failure.
+score::cpp::expected<std::int32_t, score::os::Error> slogf(const SlogCode code,


The code is not following the given design.
bIt Breaks the OSAL mock/testability design (architectural).
Every other wrapper in this file (slog2_register, slog2c, slog2f, …) is a virtual member of the Slog2 abstract base, implemented in Slog2Impl — precisely so it can be faked/mocked in unit tests. The new slogf is a free function calling ::slogf() directly, so it is unmockable and inconsistent with the entire layer. It should be a virtual method on Slog2 + override in Slog2Impl (+ the corresponding mock), matching slog2f.

Done. slogf now is a virtual a pure-virtual function of new slog interface and can be mocked via the provided mock and the free func got removed

ravindra181 · 2026-07-07T09:18:54Z

 }

+// coverity[autosar_cpp14_a8_4_1_violation]: Required for wrapper method
+score::cpp::expected<std::int32_t, score::os::Error> slogf(const SlogCode code,


Mixing two different QNX logging subsystems in a class named Slog2.
Slog2 wraps the slogger2 API (<sys/slog2.h>: slog2f, slog2c). The new code wraps the legacy slog API (<sys/slog.h> / <sys/slogcodes.h>: ::slogf, _SLOGC_NETWORK, SLOG*). These are distinct facilities with distinct code/severity macro sets. Putting legacy-slog enums and a legacy slogf wrapper inside the Slog2 (slogger2) header is confusing and conflates concerns. Clarify intent — if legacy slogf is genuinely needed, consider a separate Slog/slogf wrapper unit rather than overloading Slog2.

Done ins separate classes rather than the slog2 facility

ravindra181 · 2026-07-07T09:19:47Z

+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays) fixed-size stack buffer for embedded-friendly logging
+    char buffer[kMaxLogMessageSize];
+    // NOLINTNEXTLINE(*array-decay, *pro-type-vararg,*array-to-pointer-decay) see comment above
+    std::vsnprintf(buffer, sizeof(buffer), format, args);


std::vsnprintf return value ignored → possible use of indeterminate buffer.
char buffer[kMaxLogMessageSize]; is uninitialized. std::vsnprintf returns a negative value on encoding error; the code ignores it and unconditionally passes buffer to ::slogf(..., "%s", buffer). On error the buffer is indeterminate. Check the return: < 0 → return an error (and/or zero-initialize the buffer).

ravindra181 · 2026-07-07T09:21:05Z

    Slog2(Slog2&& other) = delete;
    Slog2& operator=(Slog2&& other) = delete;
+
+};


No Unit tests provided.

ravindra181 · 2026-07-08T14:32:46Z

+    /// @param format Printf-style format string
+    /// @param ... Format arguments
+    /// @return The number of bytes written on success, or an Error on failure.
+    virtual score::cpp::expected<std::int32_t, score::os::Error> slogf(const SlogCode code,


Just because of slogf, a new Slog class is created. Is it really necessary for this ?
Why couldnt you reuse the slog2 implementation ?

Currently we are using slogf in tracing infra and migration to slog2 would require new activities, discussions to be done with the tracing team first

ravindra181 · 2026-07-08T14:44:31Z

+    va_start(args, format);
+
+    std::string message{};
+    message.resize(message_length);


negative vsnprintf not handled in a noexcept function

slogf here is noexcept, so a throwing resize calls std::terminate. The production SlogImpl guards formatted < 0, but the mock does not. Add the same guard (return make_unexpected / empty message) before resize. Test-only, but it's a real crash path and inconsistent with the impl it mirrors.

Muhammad-Hussein-Morsy requested review from 4og, antonkri, arkjedrz and pawelrutkaq as code owners July 6, 2026 10:21

github-project-automation Bot added this to BAS - Baselibs FT Jul 6, 2026

github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Jul 6, 2026

Muhammad-Hussein-Morsy temporarily deployed to workflow-approval July 6, 2026 10:21 — with GitHub Actions Inactive

4og added the comp-osal Related to score/os component label Jul 7, 2026

ravindra181 suggested changes Jul 7, 2026

View reviewed changes

anmittag assigned Muhammad-Hussein-Morsy Jul 8, 2026

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 455d72f to 398723f Compare July 8, 2026 11:16

Muhammad-Hussein-Morsy temporarily deployed to workflow-approval July 8, 2026 11:16 — with GitHub Actions Inactive

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 11:16 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 675e3a7 to 507cc2d Compare July 8, 2026 11:22

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 11:23 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 507cc2d to 79fb324 Compare July 8, 2026 11:23

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 11:23 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 11:24 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 0a7f8fd to 79fb324 Compare July 8, 2026 11:33

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 11:33 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 79fb324 to e1ded59 Compare July 8, 2026 11:34

Muhammad-Hussein-Morsy temporarily deployed to workflow-approval July 8, 2026 11:34 — with GitHub Actions Inactive

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from e1ded59 to a9914f5 Compare July 8, 2026 12:11

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 12:11 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from a9914f5 to 147e901 Compare July 8, 2026 12:12

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 12:12 — with GitHub Actions Waiting

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 147e901 to e897513 Compare July 8, 2026 12:18

Muhammad-Hussein-Morsy temporarily deployed to workflow-approval July 8, 2026 12:18 — with GitHub Actions Inactive

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from e897513 to e389c9c Compare July 8, 2026 13:26

Muhammad-Hussein-Morsy temporarily deployed to workflow-approval July 8, 2026 13:26 — with GitHub Actions Inactive

Muhammad-Hussein-Morsy requested a review from ravindra181 July 8, 2026 13:26

hoppe-and-dreams approved these changes Jul 8, 2026

View reviewed changes

ravindra181 suggested changes Jul 8, 2026

View reviewed changes

ravindra181 reviewed Jul 8, 2026

View reviewed changes

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from e389c9c to 4dfb7a6 Compare July 8, 2026 15:08

Muhammad-Hussein-Morsy requested a deployment to workflow-approval July 8, 2026 15:08 — with GitHub Actions Waiting

Add QNX logging wrapper and update SlogCode/SlogSeverity enums

7811f51

Muhammad-Hussein-Morsy force-pushed the mumo_slog2_osal_wrapper branch from 4dfb7a6 to 7811f51 Compare July 8, 2026 15:09

Muhammad-Hussein-Morsy temporarily deployed to workflow-approval July 8, 2026 15:09 — with GitHub Actions Inactive

Muhammad-Hussein-Morsy requested a review from ravindra181 July 8, 2026 15:10

Uh oh!

Conversation

Muhammad-Hussein-Morsy commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants