mem: Mark get mem resource proxy const#346
Open
KrishaDeshkool wants to merge 4 commits into
Open
Conversation
The todo comment on the base class has been open since the method was introduced. Add a const overload as the new preferred API and mark the existing non-const one deprecated. The non-const version stays pure virtual to avoid breaking downstream consumers that haven't been updated yet; the const version defaults to nullptr at the base level and will be made pure virtual in a follow-up once all subclasses are updated.
…n-deprecated overload The constructor takes a non-const ManagedMemoryResource& so the compiler would resolve to the deprecated non-const overload. Use std::as_const to explicitly invoke the new const one.
KrishaDeshkool
requested a deployment
to
workflow-approval
July 6, 2026 16:31 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
July 6, 2026 16:31 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
…bles MyMemoryResource moves registry registration to the constructor so the const overload has no side effects. ManagedMemoryResourceTestAttorney uses std::as_const to avoid hitting the deprecated overload.
KrishaDeshkool
force-pushed
the
mark_get_mem_resource_proxy_const
branch
from
July 6, 2026 16:35
ae335f3 to
79e8432
Compare
KrishaDeshkool
temporarily deployed
to
workflow-approval
July 6, 2026 16:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
KrishaDeshkool
temporarily deployed
to
workflow-approval
July 6, 2026 16:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
KrishaDeshkool
temporarily deployed
to
workflow-approval
July 14, 2026 09:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
KrishaDeshkool
temporarily deployed
to
workflow-approval
July 14, 2026 09:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
The created documentation from the pull request is available at: docu-html |
KrishaDeshkool
marked this pull request as ready for review
July 14, 2026 15:29
KrishaDeshkool
requested review from
4og,
antonkri,
arkjedrz and
pawelrutkaq
as code owners
July 14, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initially this was created in score but, this was failing here with following err
now the internal repo is just an alias to score symbols, creating a PR here again.
mw::com PR : eclipse-score/communication#314