Add size_bytes() method to span#393
Open
mariuswbr wants to merge 1 commit into
Open
Conversation
mariuswbr
requested review from
4og,
antonkri,
arkjedrz and
pawelrutkaq
as code owners
July 17, 2026 09:18
mariuswbr
temporarily deployed
to
workflow-approval
July 17, 2026 09:18 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
mariuswbr
temporarily deployed
to
workflow-approval
July 17, 2026 09:18 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mariuswbr
commented
Jul 17, 2026
Comment on lines
+478
to
+479
| /// @testmethods TM_REQUIREMENT | ||
| /// @requirement CB-#9338069 |
Contributor
Author
There was a problem hiding this comment.
Unfortunately I really don't know how this works in baselibs.
I have seen this was added to all test cases. Let me know if I need to adjust something.
Thanks!
There was a problem hiding this comment.
Currently, the mentioned requirement-numbers are still referring to a BMW requirements-server. This will hopefully change in the mid-future 😅
Let me know if I need to adjust something.
It should be fine
Contributor
Author
|
@4og The failing pipeline asks me to contact you :). Is that acceptable? |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add size_bytes() method support for span to be compliant with std::span (C++20).