refactor: clean up shadowed and unused identifiers across com impl/tests#603
Draft
AAmbuj wants to merge 1 commit into
Draft
refactor: clean up shadowed and unused identifiers across com impl/tests#603AAmbuj wants to merge 1 commit into
AAmbuj wants to merge 1 commit into
Conversation
-rename shadowing lambda captures and local variables for clarity -replace unused result bindings with std::ignore in tests -remove unused constants and lambda captures -rename GenericProxy events map member to generic_events -silence unused parameter warnings in test overrides -keep behavior unchanged while improving static-analysis compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-rename shadowing lambda captures and local variables for clarity -replace unused result bindings with std::ignore in tests -remove unused constants and lambda captures
-rename GenericProxy events map member to generic_events -silence unused parameter warnings in test overrides -keep behavior unchanged while improving static-analysis compliance