Skip to content

add compile-time configuration for kvs maximum storage size#165

Open
atarekra wants to merge 14 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-compile-time-max-size-support
Open

add compile-time configuration for kvs maximum storage size#165
atarekra wants to merge 14 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-compile-time-max-size-support

Conversation

@atarekra

@atarekra atarekra commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces support for specifying the maximum size of the Key-Value Storage (KVS) at compile time, fulfilling the related requirement:

"The Key-Value-Storage shall support specification of its maximum size at compile time."

and resolves #161

@github-actions

github-actions Bot commented Nov 9, 2025

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: e3d6a20e-a48d-4299-b1be-c57c3a01e6b9
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (26 packages loaded, 10 targets configured)

Analyzing: target //:license-check (74 packages loaded, 10 targets configured)

Analyzing: target //:license-check (141 packages loaded, 1751 targets configured)

Analyzing: target //:license-check (151 packages loaded, 4858 targets configured)

Analyzing: target //:license-check (156 packages loaded, 8078 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8137 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8137 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8137 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8137 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10149 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10275 targets configured).
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[15 / 17] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[16 / 17] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.757s, Critical Path: 2.47s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Nov 9, 2025

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@Ahmed-Elsaka-JC

Copy link
Copy Markdown
Contributor

I see the following points :
user will face issue while flush to memory , i would say it would be better to let use know erlier while using set API to return error in case current storage size in ram exceed configured size.

@PandaeDo PandaeDo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please solve all the build errors?

@atarekra

atarekra commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

Could you please solve all the build errors?
Solved

@arkjedrz

Copy link
Copy Markdown
Contributor

I see this PR is up to date, but the change should be discussed.

@arkjedrz

Copy link
Copy Markdown
Contributor

Discussed during CFT 12.03.2026 - configuration of this parameter is okay, but the parameter should be init-time configurable.

@atarekra
atarekra force-pushed the kvs-compile-time-max-size-support branch from ec58b4a to 72f9fc0 Compare June 7, 2026 10:07
Comment thread src/cpp/tests/bm_kvs.cpp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change the file modes of cpp/hpp/BUILD files they should stay 100644

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compile-time configuration for maximum Key-Value Storage (KVS) size

5 participants