feat(clickable_plantuml): idmap-backed link resolver with canonical source matching#322
Open
AAmbuj wants to merge 2 commits into
Open
Conversation
AAmbuj
commented
Jul 7, 2026
AAmbuj
commented
Contributor
- replace linker JSON consumption with idmap-backed resolution in clickable_plantuml
- resolve definers using canonical source-path keys with deterministic matching behavior
- improve URL/link generation handling for injected PlantUML links
- add comprehensive clickable_plantuml tests for indexing, definer resolution, tie handling, self-link skip, URL modes, and encoding behavior
AAmbuj
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
AAmbuj
force-pushed
the
amsh_refactor_clickable_plantuml_idmap_tests
branch
from
8214bde to
226e736
Compare
- _load_idmap_files() indexes all .idmap.json sidecars at build-finished time - _resolve_definer() uses FQN-first + proximity tiebreak to find the defining source - _node_source_key() maps each plantuml node back to its idmap source key - Removed: _load_link_mappings(), _collect_link_data() (linker-era code)
Covers: _load_idmap_files (index building, key conflicts), _node_source_key (symlink resolution, suffix matching, tie-breaking), _resolve_definer (FQN priority, alias fallback, self-link skip, warning on tie), _build_target_url, _escape_plantuml_url, _inject_links, and on_doctree_resolved end-to-end integration.
AAmbuj
force-pushed
the
amsh_refactor_clickable_plantuml_idmap_tests
branch
from
226e736 to
769aeb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.