feat(lobster): include upstream system requirements in dependable_element traceability#326
Open
simon-d-bmw wants to merge 3 commits into
Open
Conversation
simon-d-bmw
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
simon-d-bmw
force-pushed
the
feat/310-upstream-srcs-in-de-traceability
branch
2 times, most recently
from
6fb7371 to
e92b455
Compare
When a feature_requirements() target has deps on assumed_system_requirements(),
the upstream ASR lobster files are now propagated through FeatureRequirementsInfo
to the dependable_element lobster report.
Previously, derived_from links from feature requirements to system-level
requirements produced unresolved references in the lobster coverage report
because the referenced ASR items were absent from the DE lobster config.
Changes:
- providers.bzl: add upstream_srcs field to FeatureRequirementsInfo
- private/requirements.bzl: populate upstream_srcs from AssumedSystemRequirementsInfo.srcs
in deps when building FeatureRequirementsInfo (feature kind only)
- private/component.bzl: propagate upstream_srcs alongside srcs from FeatureRequirementsInfo
- private/dependable_element.bzl: collect upstream_req_list from upstream_srcs,
add {UPSTREAM_REQ_SOURCES} substitution, include in all_lobster_inputs
- lobster/config/lobster_de.conf.tpl: add 'System Requirements' section with
{UPSTREAM_REQ_SOURCES} placeholder between Feature Requirements and Forwarded AoUs
- test/seooc_test.bzl: add analysis tests verifying upstream_srcs propagation
and DE lobster report action inputs
Closes eclipse-score#310
…test assertion
- dependable_element.bzl: replace list.extend() accumulation with depset
transitive merge so repeated ASR deps across multiple feature_requirements
targets cannot produce duplicate {UPSTREAM_REQ_SOURCES} entries or duplicate
lobster report inputs
- seooc_test.bzl: replace generic count assertion with explicit check that
'asr_trlc.lobster' is present in the lobster report action inputs
Reviewer feedback: the generic term 'upstream' was ambiguous. Renamed
throughout to 'system_req_srcs' / SYSTEM_REQ_SOURCES to explicitly name
what the field carries: system requirement (ASR) lobster files.
- providers.bzl: FeatureRequirementsInfo.upstream_srcs -> system_req_srcs
- private/requirements.bzl: upstream_lobster_depsets -> system_req_lobster_depsets
- private/component.bzl: use renamed system_req_srcs field
- private/dependable_element.bzl: upstream_req_depsets/upstream_req_list ->
system_req_depsets/system_req_list; {UPSTREAM_REQ_SOURCES} -> {SYSTEM_REQ_SOURCES}
- lobster_de.conf.tpl: {UPSTREAM_REQ_SOURCES} -> {SYSTEM_REQ_SOURCES}
- test/seooc_test.bzl, test/BUILD: renamed test impls/targets accordingly
No functional change; all 11 seooc tests pass.
simon-d-bmw
force-pushed
the
feat/310-upstream-srcs-in-de-traceability
branch
from
e92b455 to
0963e72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
feature_requirements()target hasdepsonassumed_system_requirements(), the system requirement (ASR) lobster files were not included in thedependable_elementlobster config or report. This causedderived_fromlinks from feature requirements to system-level requirements to produce unresolved references in the lobster coverage report.Changes:
providers.bzl: addsystem_req_srcsfield toFeatureRequirementsInfoprivate/requirements.bzl: populatesystem_req_srcsfromAssumedSystemRequirementsInfo.srcsin deps (feature kind only)private/component.bzl: propagatesystem_req_srcsalongsidesrcsfromFeatureRequirementsInfoprivate/dependable_element.bzl: collectsystem_req_list(deduplicated via depset), add{SYSTEM_REQ_SOURCES}substitution, include inall_lobster_inputslobster/config/lobster_de.conf.tpl: addrequirements "System Requirements" { {SYSTEM_REQ_SOURCES} }sectiontest/seooc_test.bzl: add 2 analysis tests assertingsystem_req_srcspropagation and lobster report input inclusionValidation:
bazel test //:seooc_tests(frombazel/rules/rules_score/test/) — all 11 tests pass.Closes #310