[plantuml parser] cover template special case#355
Open
hoe-jo wants to merge 1 commit into
Open
Conversation
hoe-jo
force-pushed
the
joho_fix_parser_panic
branch
from
July 21, 2026 07:33
bcdb26d to
1a1c777
Compare
Contributor
|
Looks good to me. Nit: Could we add an integration test for this? The new unit tests cover
That would make the intended scope of the change much clearer and guard against accidentally treating all |
hoe-jo
force-pushed
the
joho_fix_parser_panic
branch
from
July 21, 2026 11:41
1a1c777 to
6d87bc5
Compare
- dont panic if type cannot be resolved for Templates, e.g.
template <typename T>
decltype(...(std::declval<T>())) {};
hoe-jo
force-pushed
the
joho_fix_parser_panic
branch
from
July 21, 2026 11:49
6d87bc5 to
0c34a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.