Remove bundled logback.xml from tahu-core#445
Open
LivingLikeKrillin wants to merge 1 commit into
Open
Conversation
A library should not ship a logback backend configuration. tahu-core includes src/main/resources/logback.xml with the root logger set to TRACE, which lands on the classpath of every downstream application, forces verbose output, and collides with the application's own logging setup (which copy wins is classpath-order dependent). Logging configuration is the responsibility of the application, not a library; tahu-core should rely on slf4j-api only. The example applications under java/compat_impl keep their own logback.xml since those are apps. Fixes eclipse-tahu#276 Signed-off-by: Jooyoung Jung <livinglikekrillin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.eclipse.tahu:tahu-coreshipsjava/lib/core/src/main/resources/logback.xmlwith the root logger atTRACE. Because it sits at the root of the published jar, it lands on the classpath of every downstream application — forcing verbose TRACE output and colliding with the application's own logback configuration (which copy "wins" is classpath-order dependent). This is the problem reported in #276.A library should rely on
slf4j-apionly and leave logging backend configuration to the consuming application. This PR removes the bundled config from the library.Change
java/lib/core/src/main/resources/logback.xml(tahu-core).Deliberately out of scope (happy to add if you'd prefer)
java/compat_impl/{edge,host}keep their ownlogback.xml— those are applications, so a bundled config is appropriate there. (Optionally their root level could be loweredTRACE→INFO.)tahu-core'slogback-classicdependency could additionally be narrowed (e.g. to test scope) so the library no longer pulls a logging backend onto downstream classpaths. That's a larger change, left out of this minimal fix.Notes
org.eclipse.tahu:tahu-core:1.0.14(see Java: logback.xml introduced in 1.0.1 sets root-logger to Trace #276 for thejar tfevidence).Fixes #276