Skip to content

Add CI workflow: fmt, clippy, tests on push and PR#75

Merged
ecto merged 1 commit into
mainfrom
claude/eager-elgamal-672aac
Jul 7, 2026
Merged

Add CI workflow: fmt, clippy, tests on push and PR#75
ecto merged 1 commit into
mainfrom
claude/eager-elgamal-672aac

Conversation

@ecto

@ecto ecto commented Jul 7, 2026

Copy link
Copy Markdown
Owner

What

Adds .github/workflows/ci.yml — the repo had 236 tests but no CI (only tag-triggered release builds), so PRs merged unverified.

  • ubuntu-latest: cargo fmt --checkcargo clippy --workspace --all-targetscargo test --workspace
  • macos-latest: cargo test --workspace only
  • Toolchain setup mirrors release.yml (dtolnay/rust-toolchain@stable); caching via Swatinem/rust-cache@v2

Notes for review

  • Clippy runs without -D warnings — there are ~250 existing warnings (mostly result_large_err). It still fails on deny-by-default lints.
  • Clippy was actually red on main: 6 approx_constant errors from tests using 3.14 as an arbitrary float. Fixed with #[allow(clippy::approx_constant)] on the five affected test fns.
  • Verified locally: fmt, clippy, and all workspace tests pass.

🤖 Generated with Claude Code

Allows clippy::approx_constant on five tests using 3.14 as an
arbitrary float literal — these were deny-by-default clippy errors.
Clippy runs without -D warnings (~250 existing warnings).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
loon Ready Ready Preview, Comment Jul 7, 2026 4:58am

Request Review

@chojiai

chojiai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Choji live review — Looks good — 1 minor

Choji review — Looks good

This PR adds a CI workflow (fmt, clippy, tests on ubuntu and macos) and suppresses six pre-existing approx_constant clippy errors in test functions. The workflow is well-structured, the #[allow] annotations are narrowly scoped to the affected test functions, and the overall approach is sound. No correctness defects found.

1 minor finding
  • Minor · Structural quality — Clippy runs without --all-features, so feature-gated code paths are not linted .github/workflows/ci.yml:29
    The cargo clippy --workspace --all-targets invocation doesn't pass --all-features. If any crate has feature-gated code, those paths won't be checked by clippy. Consider adding --all-features (or at minimum documenting the omission) so the lint coverage matches what --all-targets implies for test/bench targets.

Choji ran your change live — checks failed.

No live preview was run for this CI/workflow-only change — it isn't exercisable in the running app. The cargo check verification failed due to Choji's environment not having Rust/cargo installed, not because of any defect in the PR. The change adds .github/workflows/ci.yml and a handful of #[allow(clippy::approx_constant)] annotations on test functions to fix pre-existing clippy errors on main. Both parts are straightforward and consistent with the stated intent.

Choji sandbox notice
Choji's sandbox encountered an environment error and could not complete test execution (cargo check) — this is not a reflection of your PR.
The affected checks are reported as non-blocking notices, not merge blockers.

Checks — failures

  • cargo check — FAILED

No issues found in the running app.


Was this review useful? Rate the findings → — your thumbs up or down trains Choji on what's worth flagging.

Reviewed 9b4ff32 · Choji keeps this comment up to date as you push.

@ecto ecto merged commit 80005ba into main Jul 7, 2026
8 checks passed
@chojiai

chojiai Bot commented Jul 7, 2026

Copy link
Copy Markdown

What shipped

This is a purely internal change with no user-visible effect. Automated checks (formatting, linting, and tests) now run on every pull request and push to main, ensuring code is verified before it merges.


Plain-English summary generated by Choji from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant