Add CI workflow: fmt, clippy, tests on push and PR#75
Conversation
Allows clippy::approx_constant on five tests using 3.14 as an arbitrary float literal — these were deny-by-default clippy errors. Clippy runs without -D warnings (~250 existing warnings). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Choji review — Looks good This PR adds a CI workflow (fmt, clippy, tests on ubuntu and macos) and suppresses six pre-existing 1 minor finding
Choji ran your change live — checks failed. No live preview was run for this CI/workflow-only change — it isn't exercisable in the running app. The
Checks — failures
No issues found in the running app. Was this review useful? Rate the findings → — your thumbs up or down trains Choji on what's worth flagging. Reviewed |
What shippedThis is a purely internal change with no user-visible effect. Automated checks (formatting, linting, and tests) now run on every pull request and push to main, ensuring code is verified before it merges. Plain-English summary generated by Choji from this pull request. |
What
Adds
.github/workflows/ci.yml— the repo had 236 tests but no CI (only tag-triggered release builds), so PRs merged unverified.cargo fmt --check→cargo clippy --workspace --all-targets→cargo test --workspacecargo test --workspaceonlydtolnay/rust-toolchain@stable); caching viaSwatinem/rust-cache@v2Notes for review
-D warnings— there are ~250 existing warnings (mostlyresult_large_err). It still fails on deny-by-default lints.approx_constanterrors from tests using3.14as an arbitrary float. Fixed with#[allow(clippy::approx_constant)]on the five affected test fns.🤖 Generated with Claude Code