fix(schema): drop constructor defaults when deriving update schemas#814
Open
MindfulLearner wants to merge 4 commits into
Open
fix(schema): drop constructor defaults when deriving update schemas#814MindfulLearner wants to merge 4 commits into
MindfulLearner wants to merge 4 commits into
Conversation
…ent for Struct.omit jsdoc
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
Member
|
Inheriting the behaviors of fields is desired. In what case are you considering this undesirable or a "bug"? If you need a tool to strip withConstructorDefault then i would suggest to make a helper that just does that so you can simply mapFields(flow(Struct.omit(..), stripConstructorDefaults)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: UpdateProject-style schemas are patch APIs, an omitted field means leave unchanged. When such a schema is derived from a create schema via Struct.omit/pick, a field with withConstructorDefault keeps its default. Clients call .make() implicitly on mutate, so the default silently overwrites the value the caller left untouched.
Fix:
Related: https://github.com/macs-holding/configurator/pull/851
discussion: https://discord.com/channels/1083767712431480922/1521940676416241745