Skip to content

[Chore] Set id-token: write on snapshot release job#9775

Merged
weronikaolejniczak merged 1 commit into
elastic:mainfrom
weronikaolejniczak:chore/fix-release
Jul 2, 2026
Merged

[Chore] Set id-token: write on snapshot release job#9775
weronikaolejniczak merged 1 commit into
elastic:mainfrom
weronikaolejniczak:chore/fix-release

Conversation

@weronikaolejniczak

Copy link
Copy Markdown
Contributor

Summary

Noticed on #9749, failing build: https://github.com/elastic/eui/actions/runs/28584386688/job/84754634776?pr=9749

The workflow fails on publishing a snapshot. Publishing uses npm trusted publishing (OIDC), which needs id-token: write. release.yml has it but as a reusable workflow its permissions are capped by the caller and update_kibana_dependencies.yml never granted id-token, so it was dropped to none.

Cannot be tested until merged to main.

@weronikaolejniczak weronikaolejniczak self-assigned this Jul 2, 2026
@weronikaolejniczak weronikaolejniczak added the skip-vrt Skips Visual Regression Testing job in CI (clearly state why you're using it in your PR) label Jul 2, 2026
Copilot AI review requested due to automatic review settings July 2, 2026 11:33
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner July 2, 2026 11:33
@weronikaolejniczak weronikaolejniczak changed the title [Chore] et id-token: write on snapshot release job [Chore] Set id-token: write on snapshot release job Jul 2, 2026
@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) July 2, 2026 11:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the snapshot release job in the Kibana-dependency update workflow can use npm Trusted Publishing via OIDC by explicitly granting id-token: write at the calling workflow/job level (required because reusable workflow permissions are capped by the caller).

Changes:

  • Adds explicit job permissions (id-token: write, contents: read) to the release job in update_kibana_dependencies.yml so the called release.yml workflow can successfully request an OIDC token for npm publishing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@weronikaolejniczak weronikaolejniczak merged commit d00421d into elastic:main Jul 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-vrt Skips Visual Regression Testing job in CI (clearly state why you're using it in your PR)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants