[Chore] Dispatch snapshot releases directly#9782
Conversation
8d23feb to
4dd2682
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the EUI → Kibana regression integration pipeline to dispatch snapshot publishing via workflow_dispatch (instead of workflow_call), keeping release.yml as the top-level npm trusted publishing entry point and then continuing the Kibana dependency update chain after publish metadata exists.
Changes:
- Reworked
update_kibana_dependencies.ymlto dispatchrelease.ymlfor snapshot publishing and pass Kibana integration inputs through that workflow. - Updated
release.ymlto optionally dispatch the Kibana integration workflow chain after a successful snapshot publish. - Removed
workflow_calldefinitions from the Kibana sub-workflows, standardizing onworkflow_dispatch.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/update_kibana_dependencies.yml | Switches from reusable workflow calling to dispatching release.yml for snapshot publishing + Kibana integration inputs. |
| .github/workflows/update_kibana_dependencies__prepare_changes.yml | Aligns with dispatch-based chaining and improves dispatch argument handling for optional numeric inputs. |
| .github/workflows/update_kibana_dependencies__open_pr.yml | Removes workflow_call interface, leaving this workflow dispatch-only. |
| .github/workflows/release.yml | Adds Kibana integration inputs and dispatches the Kibana workflow chain after snapshot publish metadata is available. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| # language=bash | ||
| run: | | ||
| set -euo pipefail | ||
| dependencies="$(jq -c . .release/published_packages.json)" |
There was a problem hiding this comment.
Non blocking: Could we reuse the dependencies from here?
mgadewoll
left a comment
There was a problem hiding this comment.
🟢 LGTM. I have only one non-blocking question.
In any case, we can merge and test once it's in main 👍
Summary
Closes https://github.com/elastic/eui-private/issues/719
This PR is infra-only.
Specifically, it rewrites the Kibana regression testing pipeline from
workflow_call(so called "reusable workflows" not supported by npm trusted publishing) toworkflow_dispatch.QA instructions for reviewer
No way to test this until it lands in
main. Ensure statically the file changes make sense.