refactor(web): shadcn sidebar fixes + mobile triggers#5
Open
emreycolakoglu wants to merge 1 commit into
Open
Conversation
…etailBreadcrumbBar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the shadcn Sidebar integration and adds mobile sidebar triggers.
w-[--sidebar-width]) while the project runs Tailwind v4.3.1, which compiles that to invalid CSS (width: --sidebar-width) — so the width dropped toauto, the layout-reserving gap div collapsed to zero, and the panel floated over the board content. Converted all occurrences to v4 syntax (w-(--sidebar-width)), matching the other v4 primitives, then set the width to251px(250px content + 1px right border underbox-border).SidebarRailadded to the layout (drag-to-toggle grab strip on the sidebar's right edge).SidebarTriggeradded before the back button inDetailBreadcrumbBarand before the title inBoardHeaderBar(md:hidden— the sidebar is docked at ≥md, off-canvas below).justify-centeron the menu-button variant that, combined with the still-in-flow (clipped) label span, dragged icons left of center; symmetric!p-2padding centers them like upstream shadcn.Testing
tsc --noEmit: no new errors (same 3 pre-existing).detail-breadcrumb-bar.test.tsx(wrapped inSidebarProvidernow that the bar depends on sidebar context) andsidebar-layout.test.tsx.🤖 Generated with Claude Code