NXT-15922: Fix less -> css transpile issue while 'enact transpile'#388
Open
hong6316 wants to merge 2 commits into
Open
NXT-15922: Fix less -> css transpile issue while 'enact transpile'#388hong6316 wants to merge 2 commits into
hong6316 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Fix less -> css transpile issue while
enact transpileReproduction steps
Expect: css looks fine, and panel works fine.
Actual: css looks weird, and panel not works
※ It cannot be reproduced when linking limestone directly, just
npm install @enact/limestonecases※ If you intend to link, you can reproduce the issue by running
enact transpileon Limestone first.Resolution
Fixed an issue where information was missing from CSS files when executing the
enact transpilecommand in Limestone,by injecting monkey-patch at
LessPluginRi.prototype.installintranspile.js-> Fall-throughing calc()+var() pattern
Additional Considerations
Links
NXT-15922
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)