chore: remove unused @e4a/pg-js devDependency#121
Merged
Conversation
@e4a/pg-js was listed in devDependencies but nothing in the VitePress build, config, or theme imports it. It only appears in docs prose and SDK code snippets, which stay unchanged. Removing it stops recurring dependency-bump churn on a package the site does not use. Lockfile regenerated with a plain `npm install` (not --legacy-peer-deps, per CLAUDE.md). Verified with `rm -rf node_modules && npm ci && npm run docs:build`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
VERDICT: approve
Clean sign-off. This removes the unused @e4a/pg-js entry from devDependencies — the right call per the check-dep-is-used-before-bumping rule (the package was installed but nothing in the VitePress build/config/theme imports it, so it only generated bump churn).
Verified against the diff:
- Only
package.jsonandpackage-lock.jsonchange; docs prose and SDK snippets referencing@e4a/pg-jsare untouched, as intended. - The
search-insightspeer stays inpackage-lock.json(5 occurrences on the branch), confirming the lockfile was regenerated with a plainnpm installrather than--legacy-peer-deps, sonpm ciis not broken. - PR title is valid conventional-commit (
chore:),Closes #119closes the tracking issue, and @rubenhensen is assigned as reviewer.
No blocking issues and no nits. Flipping out of draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
@e4a/pg-jsentry fromdevDependenciesinpackage.json. Nothing in the VitePress build, config, or theme imports the package. It only appears in docs prose and SDK code snippets, which document how consumers install the SDK and are left unchanged.Because it was installed but unused, it kept generating dependency-bump churn (PR #101 to 1.8.0, PR #107 to 1.10.0, then
^2.1.0) on a package the site does not use.The lockfile was regenerated with a plain
npm install(not--legacy-peer-deps, perCLAUDE.md, which drops thesearch-insightspeer and breaksnpm ci). Verified withrm -rf node_modules && npm ci && npm run docs:build; both pass and thesearch-insightspeer stays inpackage-lock.json.Closes #119