chore: drop dead pg-wasm profile spec from root manifest#246
Merged
Conversation
The root Cargo.toml carried a `[profile.release.package.pg-wasm]` `opt-level = "s"` override, but `pg-wasm` is excluded from the workspace, so the spec matched no package and Cargo warned `profile package spec `pg-wasm` in profile `release` did not match any packages` on every workspace build/test/clippy run from repo root. `pg-wasm`'s size optimization already comes from its own manifest (`[package.metadata.wasm-pack.profile.release] wasm-opt = ["-Os"]`), so removing the root block is a no-op for the wasm build and clears the warning everywhere else. Also correct the CLAUDE.md workspace-test note: a bare `cargo test --workspace` does not compile because pg-core's tests are feature-gated; document the per-crate CI invocation. Closes #245 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rubenhensen
marked this pull request as ready for review
July 20, 2026 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dead
[profile.release.package.pg-wasm](opt-level = "s") block from the rootCargo.toml.pg-wasmis listed underexcludein the workspace, so this profile spec matched no package and Cargo printedprofile package specpg-wasmin profilereleasedid not match any packageson everycargo build/test/clippyfrom repo root. The size optimization it was meant to provide already lives inpg-wasm/Cargo.toml([package.metadata.wasm-pack.profile.release] wasm-opt = ["-Os"]), so dropping the root block changes nothing about the wasm build and clears the warning everywhere else.Also fixes a stale line in
CLAUDE.md: it claimedcargo test --workspacetests the workspace, but that bare command fails to compile (pg-core's tests are feature-gated). Replaced it with the per-crate CI invocation, which is how I verified this change.Verification
cargo build --workspace: warning is gone (0 occurrences; reproduced on the base branch).cargo test --manifest-path pg-core/Cargo.toml --features test,rust,stream: 3 passed.cargo test --manifest-path pg-{cli,pkg,ffi}/Cargo.toml --all-features: all pass.cargo fmt --all -- --check: clean.No regression test is added: this is a manifest-only change with no runtime behaviour to assert; the missing warning is the observable result.
Closes #245