fix: quic stream buffer underflow on HTTP/3 Request#46250
Open
yuehaii wants to merge 6 commits into
Open
Conversation
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Contributor
|
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Contributor
|
/retest |
Contributor
|
@yuehaii Thank you for the PR. I am going to convert this to a draft; please convert back when you have added tests. |
paul-r-gall
marked this pull request as draft
July 21, 2026 13:39
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
yuehaii
marked this pull request as ready for review
July 23, 2026 03:44
Contributor
Author
hi @paul-r-gall , I have added the test case. please help review the pr when it is convenient. thanks. |
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>
Contributor
Author
|
still "Run rm -rf "$TMP_STDOUT"" related CI failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
quiche's WriteOrBufferData on any stream never goes through ScopedWatermarkBufferUpdater, so reported_buffered_bytes_ can lag behind BufferedDataBytes() whenever quiche writes directly.
Additional Description:
the fix move clearWatermarkBuffer() from both subclasses into the base class EnvoyQuicStream which owns the private member reported_buffered_bytes_, and change the drain argument from BufferedDataBytes() to reported_buffered_bytes_.
the reported_buffered_bytes_ tracks exactly what this stream has contributed to bytes_to_send_. it is incremented and decremented exclusively through updateBytesBuffered, which is only called from ScopedWatermarkBufferUpdater. the quiche internal writes bypass ScopedWatermarkBufferUpdater, so they are never counted in reported_buffered_bytes_.
Risk Level:
Low
Fixes #46087