tls: remove unused default_tls_certificate_selector.h include from server_context_impl.h#46370
Open
blurman-ai wants to merge 1 commit into
Open
Conversation
…rver_context_impl.h server_context_impl.h includes default_tls_certificate_selector.h, and that header includes server_context_impl.h back, forming an include cycle. server_context_impl.h does not use anything from default_tls_certificate_selector.h: it never names the concrete DefaultTlsCertificateSelector, DefaultTlsCertificateSelectorFactory or TlsCertificateSelectorConfigFactoryImpl. The only certificate-selector type it uses is the abstract Ssl::TlsCertificateSelectorPtr, which comes from envoy/ssl/handshaker.h (already included directly). Removing the include breaks the cycle with no call-site changes. The files that use the concrete DefaultTlsCertificateSelector (server_context_config_impl.cc and the QUIC proof-source test) already include default_tls_certificate_selector.h directly. Signed-off-by: Sergey Blekher <287965768+blurman-ai@users.noreply.github.com>
blurman-ai
requested a deployment
to
external-contributors
July 24, 2026 13:32 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
|
Hi @blurman-ai, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server_context_impl.hincludesdefault_tls_certificate_selector.h, and that header includesserver_context_impl.hback, forming an include cycle.server_context_impl.hdoes not use anything fromdefault_tls_certificate_selector.h: it never names the concreteDefaultTlsCertificateSelector,DefaultTlsCertificateSelectorFactoryorTlsCertificateSelectorConfigFactoryImpl. The only certificate-selector type it uses is the abstractSsl::TlsCertificateSelectorPtr, which comes fromenvoy/ssl/handshaker.h(already included directly).Removing the include breaks the cycle with no call-site changes. The files that use the concrete
DefaultTlsCertificateSelector(server_context_config_impl.ccand the QUIC proof-source test) already includedefault_tls_certificate_selector.hdirectly.AI assistance: this cleanup was found with an open-source include-graph checker (archcheck) run over the Envoy include graph, and the verification above was assisted by an AI tool; I understand and take full ownership of the change.
Commit Message
tls: remove unused default_tls_certificate_selector.h include from server_context_impl.h
Additional Description
Pure include-cleanup, no functional change.
Risk Level
Low
Testing
N/A (removes an unused include; existing CI build/link covers it)
Docs Changes
N/A
Release Notes
None