build: Bump to LLVM 22#46371
Merged
Merged
Conversation
Signed-off-by: Jonh Wendell <jwendell@redhat.com> Co-authored-by: Ryan Northey <ryan@synca.io>
The hermetic LLVM toolchain makes clang always available through bazel regardless of system compilers. Update the `gcc` and `none` service expectations to reflect that clang-libc++ is the default even without a system clang installed. Only `--config=gcc` fails when gcc is absent, since it explicitly sets `CC=gcc`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Backport of upstream `toolchains_llvm` commit `68822c1` (PR envoyproxy#748, v1.8.0): on macOS, `toolchains_llvm` v1.7.0 compiles with the hermetic toolchain's bundled libc++ headers but links against the Xcode SDK's system `libc++.tbd`. LLVM 21+ moved `std::__hash_memory` out of line, exposing this ABI mismatch as an undefined symbol at link time. The fix adds `-nostdinc++` and `-cxx-isystem <sysroot>/usr/include/c++/v1` so macOS uses the SDK's libc++ headers end-to-end, matching link-time behavior. Remove this patch when upgrading to `toolchains_llvm` v1.8.0+. Fix LuaJIT linking on macOS: the hermetic clang defaults to the system `ld` (Xcode's linker) when `-fuse-ld` is not passed. The system `ld` dynamically loads libc++ at runtime and picks up the hermetic toolchain's `libc++.1.0.dylib`, which is missing `___cxa_demangle` — causing `ld` itself to crash. Pass `-fuse-ld=lld` and `--ld-path=ld64.lld` to both `HOST_LDFLAGS` and `TARGET_LDFLAGS` in `luajit_build.sh` so all link steps use the hermetic `ld64.lld` instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
requested review from
KBaichoo,
RyanTheOptimist,
abeyad,
agrawroh,
botengyao,
danzh2010,
kyessenov,
mathetake,
mattklein123,
nezdolik,
phlax,
ravenblackx,
tonya11en,
wbpcode,
yanavlasov,
yanjunxiang-google and
zuercher
as code owners
July 24, 2026 13:42
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
repokitteh-read-only
Bot
removed
the
deps
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
repokitteh-read-only
Bot
added
the
deps
phlax
approved these changes
Jul 24, 2026
repokitteh-read-only
Bot
removed
the
deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.