fix: prevent filter dropdown from opening when disabled#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabledprop was only applied to the innerButton, so the dropdown still opened on click/keyboard because Radix'sDropdownMenuTriggerhas its own open handlers. Passingdisabledto the trigger now short-circuits those handlers so the menu won't open when disabled.headingprop type fromstringtoReact.ReactNodeso it can accept a badge alongside the heading text (used for issued credentials).Changes
filter-dropdown.tsx— passdisabledtoDropdownMenuTriggerin addition to theButton.section-heading.tsx— widenheadingprop type toReact.ReactNode.Testing
FilterDropdownno longer opens via click or keyboard, while the enabled state is unchanged.SectionHeadingaccepts both plain text and a text +Badgecombination.