Fix stale error handling calls in Submodules/Noah-MP and code clean up #3446
Open
akashdhruv wants to merge 7 commits into
Open
Fix stale error handling calls in Submodules/Noah-MP and code clean up #3446akashdhruv wants to merge 7 commits into
akashdhruv wants to merge 7 commits into
Conversation
akashdhruv
changed the title
akashdhruv
commented
Jul 14, 2026
| // land-free ranks never block land-owning ones. | ||
| const int color = noahmpio_vect.empty() ? MPI_UNDEFINED : 1; | ||
| MPI_Comm land_comm = MPI_COMM_NULL; | ||
| MPI_Comm_split(ParallelDescriptor::Communicator(), color, |
Collaborator
Author
There was a problem hiding this comment.
@AMLattanzi @demetresfytanides
Restart and plotting now uses a communicator split to make sure that land-free ranks don't call the restart routines.
Collaborator
There was a problem hiding this comment.
Restart on GPU on Perlmutter for the Joplin tornado ran 901 steps with the comparison done restarting from chk00900:
alattanz@nid001992:/pscratch/sd/a/alattanz/Tornado_Modeling/LargeDomain> /global/homes/a/alattanz/gitcode/amrex/Tools/Plotfile/fcompare.gnu.x86-milan.ex plt00901 plt00901.old.0041678/
variable name absolute error relative error
(||A - B||) (||A - B||/||A||)
----------------------------------------------------------------------------
level = 0
density 9.320100247e-11 7.593404996e-11
rhotheta 2.790500275e-08 8.089002137e-11
rhoQ1 2.935495978e-10 1.359912433e-08
x_velocity 2.76200774e-07 4.952383759e-09
y_velocity 1.386038129e-07 4.101337157e-09
z_velocity 1.350622876e-08 7.911571706e-09
temp 4.997571068e-08 1.649234272e-10
theta 1.356227131e-09 2.664268442e-12
KE 0 0
reflectivity 1.765698698e-12 4.769183266e-14
max_reflectivity 1.749711487e-13 4.726001526e-15
precipitable 9.482278074e-09 2.022764498e-10
vorticity_x 1.84163771e-09 1.267172822e-08
vorticity_y 4.277757693e-09 3.739945877e-08
vorticity_z 4.644061736e-10 2.397279276e-08
helicity 9.563219661e-11 8.066633911e-11
local_helicity 1.74490858e-12 1.231683283e-09
pres_hse 0 0
pressure 5.733368744e-05 5.639808047e-10
pres_hse_x 0 0
pres_hse_y 0 0
z_phys 0 0
lat_m 0 0
lon_m 0 0
Kmv 0 0
Kmh 0.0001669565554 7.896923137e-08
Khv 0 0
Khh 0.0005008696661 7.896923137e-08
qv 2.649125676e-10 1.372818724e-08
qc 0 0
qrain 3.98719915e-18 8.103696072e-15
qsnow 2.109112039e-19 7.930226988e-16
qgraup 0 0
qt 2.649125676e-10 1.372818724e-08
qp 3.98719915e-18 8.103696072e-15
Collaborator
Author
There was a problem hiding this comment.
Is the development branch producing correct restart?
Collaborator
There was a problem hiding this comment.
Same test with development. I confirmed hard 0 when I turn off radiation and Noah. I can toggle just radiation now.
alattanz@nid001280:/pscratch/sd/a/alattanz/Tornado_Modeling/LargeDomain> /global/homes/a/alattanz/gitcode/amrex/Tools/Plotfile/fcompare.gnu.x86-milan.ex plt00901 plt00901.old.0634534/
variable name absolute error relative error
(||A - B||) (||A - B||/||A||)
----------------------------------------------------------------------------
level = 0
density 1.257569604e-10 1.024585045e-10
rhotheta 3.752279554e-08 1.087697484e-10
rhoQ1 1.357159003e-10 6.2872422e-09
x_velocity 2.0856674e-07 3.739680181e-09
y_velocity 1.025461351e-07 3.034377377e-09
z_velocity 2.002397652e-08 1.172948674e-08
temp 2.578838121e-08 8.510347465e-11
theta 6.146478881e-10 1.207457759e-12
KE 0 0
reflectivity 1.907807246e-12 5.153020725e-14
max_reflectivity 1.243449788e-13 3.358579616e-15
precipitable 6.989388623e-09 1.490979075e-10
vorticity_x 1.225795816e-09 8.434361404e-09
vorticity_y 2.554708116e-09 2.23352255e-08
vorticity_z 3.512208996e-10 1.813012695e-08
helicity 1.918038619e-10 1.617885191e-10
local_helicity 1.829069754e-12 1.291091948e-09
pres_hse 0 0
pressure 2.937897807e-05 2.889955379e-10
pres_hse_x 0 0
pres_hse_y 0 0
z_phys 0 0
lat_m 0 0
lon_m 0 0
Kmv 0 0
Kmh 0.0001616945089 7.648074721e-08
Khv 0 0
Khh 0.0004850835266 7.648074721e-08
qv 1.22662238e-10 6.356548603e-09
qc 0 0
qrain 9.204647481e-18 1.870778282e-14
qsnow 2.332516979e-19 8.770223192e-16
qgraup 0 0
qt 1.22662238e-10 6.356548603e-09
qp 9.204647481e-18 1.870778282e-14
Collaborator
There was a problem hiding this comment.
Development with all the physics EXCEPT Noah:
alattanz@nid001280:/pscratch/sd/a/alattanz/Tornado_Modeling/LargeDomain> /global/homes/a/alattanz/gitcode/amrex/Tools/Plotfile/fcompare.gnu.x86-milan.ex plt00896 plt00896.old.9497947/
variable name absolute error relative error
(||A - B||) (||A - B||/||A||)
----------------------------------------------------------------------------
level = 0
density 0 0
rhotheta 0 0
rhoQ1 0 0
x_velocity 0 0
y_velocity 0 0
z_velocity 0 0
temp 0 0
theta 0 0
reflectivity 0 0
max_reflectivity 0 0
vorticity_x 0 0
vorticity_y 0 0
vorticity_z 0 0
pres_hse 0 0
pressure 0 0
z_phys 0 0
lat_m 0 0
lon_m 0 0
qv 0 0
qc 0 0
qrain 0 0
qsnow 0 0
qgraup 0 0
qt 0 0
qp 0 0
PLOTFILE AGREE
Collaborator
Author
There was a problem hiding this comment.
Thank you. This is very helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: