Add support for extended CMD_BACKUP/MASK#108
Merged
Merged
Conversation
Member
|
The point of the legacy or ETe suffix is so that each engine has its own namespace tbh. |
Collaborator
Author
Sure, but I see little to no point in reimplementing the exact same thing under a different namespace & extension number, unless you want to modify the implementation somehow. In general, coordination between downstream forks for common features and extensions would be healthy, but there doesn't seem to be any sort of effort done from either side regarding that, so we just can't have nice things ¯\_(ツ)_/¯ |
Member
|
The numbers don't have to match as long as the mod requests the proper string |
Support doubling 'CMD_BACKUP/MASK' buffers with 'CG_CMDBACKUP_EXT' engine extension. This allows mods to request a higher buffers for user commands, increasing the maximum FPS that clients can use before high FPS combined with high ping will start dropping user commands. The cgame import value matches what ET: Legacy uses, for interoperability with ETe + legacy mod, and to make it such that mods don't need to add support for both explicitly.
Collaborator
Author
|
The number is now 185, sequentially after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support doubling
CMD_BACKUP/MASKbuffers withCG_CMDBACKUP_EXTengine extension. This allows mods to request a higher buffers for user commands, increasing the maximum FPS that clients can use before high FPS combined with high ping will start dropping user commands.The cgame import value matches what ET: Legacy uses, for interoperability with ETe + legacy mod, and to make it such that mods don't need to add support for both explicitly.