Skip to content

[Collatz Conjecture Dig Deeper]: Corrections & Edit#4250

Merged
BethanyG merged 4 commits into
exercism:mainfrom
BethanyG:fix-collatz-dig-deeper
Jun 23, 2026
Merged

[Collatz Conjecture Dig Deeper]: Corrections & Edit#4250
BethanyG merged 4 commits into
exercism:mainfrom
BethanyG:fix-collatz-dig-deeper

Conversation

@BethanyG

Copy link
Copy Markdown
Member

See issue #4197 for details.

I tried my best to address the awkwardness, but failed in some cases. Recursion might need a re-write.

Comment thread exercises/practice/collatz-conjecture/.approaches/introduction.md Outdated

The key to this exercise is to check if the number is even or odd and then perform the correct operation.
Under this process you are supposed to count how many steps it takes to get to one.
Under this process (_if the data is not [pathological][collatz-pathological]_), the result will settle at 1.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link does seem useful, but it being right here confused me, as it does not mention the word "pathological".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we keep it. Unless you'd like to replace it with a def of "pathological data"? The point being ... and I was frustrated I couldn't find a clearer article, but if you use something like 27 (which takes 111 steps to settle), or some other numbers, it can take a long time to come to 1. That being said, we know all numbers up to about 2^71 will settle, it is just a matter of the number of steps.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to suggestions on how to describe the link.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went with

(if the input number doesn't create an excessively [long cycle][collatz-pathological]), the result will settle at 1.

Comment thread exercises/practice/collatz-conjecture/.approaches/introduction.md Outdated
Comment thread exercises/practice/collatz-conjecture/.approaches/if-else/content.md Outdated
Comment thread exercises/practice/collatz-conjecture/.approaches/ternary-operator/content.md Outdated
Comment thread exercises/practice/collatz-conjecture/.approaches/ternary-operator/content.md Outdated
"introduction": {
"authors": ["bethanyg", "meatball133"],
"contributors": []
"contributors": ["Yrahcaz7"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the usernames had to be in lowercase... Does the casing actually not matter?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I've had cases where I swear my name in lowercase didn't count ... but IDK for sure. Maybe keep an eye out and see? We can come back later and change things.

Comment thread exercises/practice/collatz-conjecture/.approaches/recursion/content.md Outdated
Comment thread exercises/practice/collatz-conjecture/.approaches/recursion/content.md Outdated
Comment thread exercises/practice/collatz-conjecture/.articles/performance/content.md Outdated
@Yrahcaz7

Copy link
Copy Markdown
Contributor

I think the approach docs look a lot better now. recursion might still be a little awkward, but it's not that bad.

Comment thread exercises/practice/collatz-conjecture/.approaches/recursion/content.md Outdated
BethanyG and others added 2 commits June 22, 2026 16:19
Suggestions from review.

Co-authored-by: Yrahcaz <74512479+Yrahcaz7@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@BethanyG BethanyG requested a review from Yrahcaz7 June 22, 2026 23:32
@BethanyG BethanyG merged commit 4d03daf into exercism:main Jun 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants