chore: remove redundant CI steps - #91
Open
itsoyou wants to merge 3 commits into
Open
Conversation
| for p in path: | ||
| paths: list[list[str]] = [[path]] | ||
| elif len(path) == 0 or isinstance(path[0], str): | ||
| paths = [cast("list[str]", path)] |
Member
There was a problem hiding this comment.
oh wow, is that supposed to be a string of the types?
Member
Author
There was a problem hiding this comment.
Seems like they are using path list, so the path is already string type when it is given as an input.
and it's not the filesystem path, but JWT claim path, which shouldn't be Path
Member
There was a problem hiding this comment.
I mean, is paths = [cast("list[str]", path)] the casting supposed to be in quotes? Shouldn't it be like:paths = [cast(list[str], path)] so the types register? Does cast() take a nested Typing? 🤔 Now I'm curious
Comment on lines
+101
to
+114
| ignore = [ | ||
| "FBT001", | ||
| "FBT002", | ||
| "TRY002", | ||
| "TRY003", | ||
| "PLW0603", | ||
| "N802", | ||
| "N815", | ||
| "SLF001" | ||
| ] | ||
|
|
||
| [tool.ruff.lint.per-file-ignores] | ||
| "tests/*" = ["S101", "S105", "PLR2004", "N803", "SLF001", "UP035", "PT019", "ARG002", "ARG001"] | ||
|
|
Member
There was a problem hiding this comment.
I see we are adding these. Are any ignored by default? If you could, please add a little descriptive comment about what it is ignoring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYN-76
SYN-66