docs(home): honest home-page copy + move Performance & Benchmarks to sidebar bottom#58
Merged
Merged
Conversation
…sidebar bottom Carry over the remaining home-page copy refinements from task/perf-benchmark-methodology that were not part of the squash-merged benchmark PR: - Drop the unsubstantiated 'fastest possible execution path' claim from the Asynchronous Core module. - Reframe the hero and footer copy around 'batteries-included' rather than raw speed/SLA marketing. Also move the 'Performance & Benchmarks' entry out of 'Digging Deeper' to a standalone section at the very bottom of the docs sidebar.
bedus-creation
commented
Jul 8, 2026
bedus-creation
left a comment
Contributor
Author
There was a problem hiding this comment.
Code Reviewer verdict: APPROVE ✅ (posted as comment — GitHub blocks self-approve on this account)
Reviewed the full diff and verified locally:
vitepress buildcompletes successfully on the PR branch (branchtask/673-perf-leftover-sidebar).- Sidebar reorder is structurally valid:
Performance & Benchmarksmoved from Digging Deeper to a standalone top-level entry after Testing. Exactly one/docs/benchmarksreference remains (no duplicate); targetdocs/benchmarks.mdexists (no dead link). - Home-copy de-hyping is accurate/grammatical; no residual "high-performance"/"fastest"/"engineered for speed" claims remain in home components.
- Confirmed it does NOT revert #56 decisions: "AI & Agents" title preserved, hero stats not re-added.
No blockers — safe to merge once QA passes.
…red for Performance'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #56 was squash-merged into
mainand already carried most of thetask/perf-benchmark-methodologywork (benchmark page, real web-frameworks numbers, Observability→AI module swap, removal of the SLA/P99 hero stats, and the sidebar entry). This PR (basemain, not the merged #56) brings over the remaining meaningful changes from that branch thatmaindid not yet have, plus the sidebar move requested in task #673.Changes
1. Remaining honest home-page copy (not covered by #56)
CoreModules.vue— drop the unsubstantiated "fastest possible execution path" claim from the Asynchronous Core module.HeroSection.vue— reframe the hero description around "batteries-included" instead of "high-performance boilerplate engineered for speed".SiteFooter.vue— same de-hyping for the footer tagline and copyright line.2. Sidebar reorder (task #673)
Performance & Benchmarksout of the Digging Deeper group to a standalone entry at the very bottom of the docs sidebar (after Testing).Deliberately excluded
To avoid reverting decisions
mainalready made independently in #56, this PR does not touch:mainchose "AI & Agents"; the old branch had "AI & MCP").mainremoved it entirely; the old branch re-added a "100% Test Coverage" stat).mainis ahead of the old branch (docs/ai/agent.md,docs/fastapi.md,docs/getting-started.md, etc.) — diffing the raw branch would have reverted that newer work.Verification
vitepress buildcompletes successfully with the new sidebar structure.