fastapi_startkit: pin to 0.47.0 (FastAPI 0.139) to match baseline#9
Merged
Conversation
The previous range resolved fastapi-startkit to 0.46.x -> FastAPI 0.124.4, while the fastapi baseline entry runs FastAPI 0.139. Pin to 0.47.0 so both Python entries benchmark on the same FastAPI/Starlette (0.139.0 / 1.3.1), making the comparison apples-to-apples. Idiomatic include_router registration is kept unchanged. route_spec.rb passes 6/6 on the 0.139 Docker build.
7280969 to
11e17bf
Compare
Keep the benchmark's reported version label in sync with the 0.47.0 pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the committed
fastapi_startkitbenchmark with thefastapibaseline on the same FastAPI version (task the-benchmarker#670, decision c).Previously
python/fastapi_startkit/pyproject.tomlusedfastapi-startkit[fastapi]>=0.46,<0.47, which resolves startkit 0.46.x → FastAPI 0.124.4 / Starlette 0.50, while thefastapibaseline entry runs FastAPI 0.139 / Starlette 1.3.1 — an apples-to-oranges comparison (and a mismatch vs the published README numbers, which were measured on 0.139).Change
fastapi-startkit[fastapi]==0.47.0→ FastAPI 0.139.0 / Starlette 1.3.1, matching the baseline.include_routerregistration is kept unchanged. The flat-route candidate (PR fastapi_startkit: flat route registration (avoid include_router) — candidate #8) was investigated and deliberately not adopted: on 0.124 it's a structural no-op, and on 0.139 it bypasses startkit's representative router registration to dodge an intended FastAPI behavior (_IncludedRouternested resolution). The ~10-14% include_router cost is a real, representative cost on 0.139 and is shown, not hidden.Verification
fastapi 0.139.0,fastapi-startkit 0.47.0,starlette 1.3.1(confirmed viapip showinside the image).route_spec.rbpasses 6/6 via the real Docker + rspec harness (uvicorn image).Related
_IncludedRouter.