Skip to content

fastapi_startkit: pin to 0.47.0 (FastAPI 0.139) to match baseline#9

Merged
bedus-creation merged 2 commits into
developfrom
task/670-fastapi-startkit-0470
Jul 8, 2026
Merged

fastapi_startkit: pin to 0.47.0 (FastAPI 0.139) to match baseline#9
bedus-creation merged 2 commits into
developfrom
task/670-fastapi-startkit-0470

Conversation

@bedus-creation

Copy link
Copy Markdown

Summary

Aligns the committed fastapi_startkit benchmark with the fastapi baseline on the same FastAPI version (task the-benchmarker#670, decision c).

Previously python/fastapi_startkit/pyproject.toml used fastapi-startkit[fastapi]>=0.46,<0.47, which resolves startkit 0.46.x → FastAPI 0.124.4 / Starlette 0.50, while the fastapi baseline entry runs FastAPI 0.139 / Starlette 1.3.1 — an apples-to-oranges comparison (and a mismatch vs the published README numbers, which were measured on 0.139).

Change

  • Pin to fastapi-startkit[fastapi]==0.47.0FastAPI 0.139.0 / Starlette 1.3.1, matching the baseline.
  • Idiomatic include_router registration is kept unchanged. The flat-route candidate (PR fastapi_startkit: flat route registration (avoid include_router) — candidate #8) was investigated and deliberately not adopted: on 0.124 it's a structural no-op, and on 0.139 it bypasses startkit's representative router registration to dodge an intended FastAPI behavior (_IncludedRouter nested resolution). The ~10-14% include_router cost is a real, representative cost on 0.139 and is shown, not hidden.

Verification

  • Docker image resolves fastapi 0.139.0, fastapi-startkit 0.47.0, starlette 1.3.1 (confirmed via pip show inside the image).
  • route_spec.rb passes 6/6 via the real Docker + rspec harness (uvicorn image).

Related

The previous range resolved fastapi-startkit to 0.46.x -> FastAPI 0.124.4,
while the fastapi baseline entry runs FastAPI 0.139. Pin to 0.47.0 so both
Python entries benchmark on the same FastAPI/Starlette (0.139.0 / 1.3.1),
making the comparison apples-to-apples. Idiomatic include_router registration
is kept unchanged. route_spec.rb passes 6/6 on the 0.139 Docker build.
@bedus-creation bedus-creation force-pushed the task/670-fastapi-startkit-0470 branch from 7280969 to 11e17bf Compare July 8, 2026 17:20
Keep the benchmark's reported version label in sync with the 0.47.0 pin.
@bedus-creation bedus-creation merged commit ba84092 into develop Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant