Add regression matrix for heterogeneous union annotations#735
Draft
wbarnha wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing.Unionand PEP 604 (X | Y) annotations.Current finding
Mode 0.5.3 now correctly recognizes PEP 604 unions. Faust's
UnionNodeonly collapses unions when every member is a model or every member is a literal scalar. A union such asstr | list | dict | Nonetherefore reachesUnionNode.build()and raisesNotImplementedErrorduringRecordclass creation.The issue #80 cases are marked strict xfail in this draft so CI documents the existing failure while the implementation fix is designed. Ambiguous model/scalar and coercion-sensitive unions remain passing negative tests.