Development#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 550a85dac5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if trace_id and "trace_id" not in data and "x_ferro_trace_id" not in data: | ||
| data["trace_id"] = trace_id |
There was a problem hiding this comment.
When an endpoint returns a bare JSON array and the gateway includes x-request-id, this assignment treats the list as a dict and raises TypeError before callers can handle it. The SDK already supports list-shaped responses in places like Admin.keys.list() (data if isinstance(data, list) ...), so /admin/keys or similar list endpoints that include the standard request-id header will regress; parse the JSON as Any and only inject header metadata into dict bodies.
Useful? React with 👍 / 👎.
| """Legacy completion-style adapter — wraps chat completions with a single user message.""" | ||
|
|
||
| model: str = Field(...) | ||
| base_url: str | None = None |
There was a problem hiding this comment.
The integration still advertises requires-python = ">=3.9", but the new modules use PEP 604 annotations such as str | None, which Python 3.9 cannot parse even with from __future__ import annotations. Users on the advertised Python 3.9 will get a SyntaxError on import; either require Python >=3.10 for this package or rewrite these annotations with Optional[...]/Union[...].
Useful? React with 👍 / 👎.
1 participant
No description provided.