INTER-2335: Upgrade cookie dependency to v2 - #258
Conversation
Coverage report
Test suite run success286 tests passing in 95 suites. Report generated by 🧪jest coverage report action from 421d617 Show full coverage report
|
There was a problem hiding this comment.
Pull request overview
Upgrades the cookie dependency to v2 and adapts the internal cookie-filtering utility to the new parsing API, keeping request header filtering behavior in place before proxying to the Fingerprint API.
Changes:
- Bump
cookiedependency from1.1.1to2.0.1. - Switch cookie parsing usage from
parsetoparseCookiein the header filtering helper. - Update lockfile entries to reflect the new dependency version.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/cookie.ts | Updates the cookie parsing callsite to use parseCookie while preserving the existing filtering logic. |
| package.json | Bumps the cookie dependency to 2.0.1. |
| pnpm-lock.yaml | Records the updated cookie@2.0.1 resolution and snapshot entries. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
91aa955 to
e8a10bb
Compare
Upgrade the `cookie` package from `1.1.1` to `2.0.1`. Related-Task: INTER-2335
e8a10bb to
88bba44
Compare
TheUnderScorer
left a comment
There was a problem hiding this comment.
Looks good, left one comment/suggestion, thanks!
🚀 Following releases will be created using changesets from this PR:@fingerprint/cloudflare-worker-proxy@1.7.1Patch Changes
|
mcnulty-fp
left a comment
There was a problem hiding this comment.
LGTM!
FWIW, in the Flow worker, we created our implementation of cookie header field parsing, based on jshttp/cookie, that handles multiple cookies with the same name correctly. Might be worth considering if the cloudflare worker should follow suit at some point. Further details are in this PR discussion.
Summary
cookiefrom1.1.1to2.0.1.parseCookiefunction.Customer impact
None. Cookie parsing is used internally to filter the
_iidtcookie from request headers before proxying to the Fingerprint API.Benefits