snapshot, pool: use acquire_nolock to avoid CAS in snapin - #10589
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional non-atomic pool acquisition path to reduce snapshot-loading CAS overhead.
Changes:
- Implements and tests
acquire_nolockfor parallel pools. - Uses the new API for snapshot account allocation.
- Adds regression coverage for incremental snapshot retries and pool reuse.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/util/tmpl/fd_pool_para.c |
Adds optional non-atomic acquisition. |
src/util/tmpl/test_pool_para.c |
Tests nolock pool behavior. |
src/flamenco/accdb/fd_accdb_private.h |
Enables nolock acquisition for the account pool. |
src/flamenco/accdb/fd_accdb.c |
Uses nolock acquisition during snapshot loading. |
src/flamenco/accdb/fd_accdb.h |
Documents exclusive snapshot pool access. |
src/flamenco/accdb/test_accdb.c |
Tests pool reuse across incremental retries. |
Performance Measurements ⏳
|
Performance Measurements ⏳
|
mjain-jump
commented
Jul 30, 2026
mjain-jump
force-pushed
the
mjain/snapshot-acquire-unsafe
branch
2 times, most recently
from
July 30, 2026 16:40
f51fb3c to
0bf1588
Compare
Performance Measurements ⏳
|
mjain-jump
enabled auto-merge (squash)
July 30, 2026 16:48
mjain-jump
force-pushed
the
mjain/snapshot-acquire-unsafe
branch
from
July 30, 2026 22:17
07ecc9f to
4c27db3
Compare
mjain-jump
force-pushed
the
mjain/snapshot-acquire-unsafe
branch
from
July 30, 2026 22:17
4c27db3 to
10a2c3e
Compare
Performance Measurements ⏳
|
ripatel-fd
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.