Fix ckan.favicon path (404)#213
Merged
Merged
Conversation
favicon.ico lives at the root of ckanext-unaids's theme/public directory (mounted at site root via add_public_directory), not under /images/ - that subdirectory only has badges/. The old path 404'd.
cooper667
enabled auto-merge (squash)
July 14, 2026 07:28
A-Souhei
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://adr.unaids.org/images/favicon.ico 404s.
favicon.icoactually lives at the root of ckanext-unaids'stheme/publicdirectory (mounted at site root viaadd_public_directory), not under/images/— that subdirectory only containsbadges/. Fixesdeploy/base.inito point at/favicon.ico.