Skip to content

Fix active revenue metrics and sensor filters#271

Draft
roncodes wants to merge 8 commits into
mainfrom
dev-v0.6.56
Draft

Fix active revenue metrics and sensor filters#271
roncodes wants to merge 8 commits into
mainfrom
dev-v0.6.56

Conversation

@roncodes

Copy link
Copy Markdown
Member

Summary

  • Add a shared active revenue query for FleetOps metrics so deleted or inactive orders and invoices do not continue contributing to earnings.
  • Apply the shared active revenue rules to earnings, revenue trend, and average order value calculations.
  • Fix sensor status and type table filters so option objects render with their label/value contract instead of displaying object text.
  • Add focused source-contract and controller coverage for the metric helper and sensor filter configuration.

Validation

  • PHP syntax checks passed for the touched FleetOps metric files and source-contract test.
  • ESLint passed for the touched sensor controllers and unit tests.
  • Cached diff whitespace check passed.
  • Focused Ember tests built successfully, but the local Testem runner failed afterward because its CommonJS loader tried to require an ESM execa package.
  • Local Pest/PHPUnit execution was blocked by missing or mismatched server test dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant