refactor!: reapply clustering dim-rename layer drop via tsam-xarray DimNames (#739)#748
Draft
FBumann wants to merge 1 commit into
Draft
refactor!: reapply clustering dim-rename layer drop via tsam-xarray DimNames (#739)#748FBumann wants to merge 1 commit into
FBumann wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Revert of the revert: reapplies #739 (dropped clustering dim-rename layer,
DimNames(period='original_cluster'),tsam_xarray >= 0.6.4) on top of main after #746 removed it.#739 carries a BREAKING CHANGE for persisted clustering artifacts — JSON/netCDF saved by flixopt ≤ 7.2.x no longer load. Per the policy in #746/#747, main stays fully v7-compatible; this change ships with v8.0.0.
This PR exists as the tracked home for the reapplication on main. It becomes redundant if the
v8integration branch (#747, which already contains #739) lands first — in that case, close it.🤖 Generated with Claude Code