Skip to content

refactor!: reapply clustering dim-rename layer drop via tsam-xarray DimNames (#739)#748

Draft
FBumann wants to merge 1 commit into
mainfrom
reapply-739-dim-names
Draft

refactor!: reapply clustering dim-rename layer drop via tsam-xarray DimNames (#739)#748
FBumann wants to merge 1 commit into
mainfrom
reapply-739-dim-names

Conversation

@FBumann

@FBumann FBumann commented Jul 23, 2026

Copy link
Copy Markdown
Member

What

Revert of the revert: reapplies #739 (dropped clustering dim-rename layer, DimNames(period='original_cluster'), tsam_xarray >= 0.6.4) on top of main after #746 removed it.

⚠️ DO NOT MERGE until v8.0.0

#739 carries a BREAKING CHANGE for persisted clustering artifacts — JSON/netCDF saved by flixopt ≤ 7.2.x no longer load. Per the policy in #746/#747, main stays fully v7-compatible; this change ships with v8.0.0.

This PR exists as the tracked home for the reapplication on main. It becomes redundant if the v8 integration branch (#747, which already contains #739) lands first — in that case, close it.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a3c8614-97d2-4258-9cdf-868dff013843

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reapply-739-dim-names

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant