Skip to content

Fix Android playback events after orientation change - #58

Open
TheJim92 wants to merge 1 commit into
flutterwtf:masterfrom
TheJim92:fix/android-rotation-events
Open

Fix Android playback events after orientation change#58
TheJim92 wants to merge 1 commit into
flutterwtf:masterfrom
TheJim92:fix/android-rotation-events

Conversation

@TheJim92

Copy link
Copy Markdown

Description

On Android, rotating the device while playing a VR video causes the position, duration and state EventChannels to stop emitting events.

The player itself continues playing correctly, but Flutter no longer receives playback updates, causing the progress bar and playback timer to freeze.

Cause

dispose(true) is called during orientation changes.

Although the player is intentionally kept alive when isRebuilding == true, the EventChannel sinks are still cleared, so subsequent playback events are discarded.

Fix

Only clear the EventChannel sinks when the player is actually destroyed (isRebuilding == false).

This preserves the existing event subscriptions during orientation changes while keeping the original behaviour for a real dispose.

Tested
Android device
VR video playback
Device rotation while playing
Progress bar continues updating correctly after rotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant