Fix Android playback events after orientation change - #58
Open
TheJim92 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android, rotating the device while playing a VR video causes the position, duration and state EventChannels to stop emitting events.
The player itself continues playing correctly, but Flutter no longer receives playback updates, causing the progress bar and playback timer to freeze.
Cause
dispose(true) is called during orientation changes.
Although the player is intentionally kept alive when isRebuilding == true, the EventChannel sinks are still cleared, so subsequent playback events are discarded.
Fix
Only clear the EventChannel sinks when the player is actually destroyed (isRebuilding == false).
This preserves the existing event subscriptions during orientation changes while keeping the original behaviour for a real dispose.
Tested
Android device
VR video playback
Device rotation while playing
Progress bar continues updating correctly after rotation