Windows: Use native Shell API to support third-party file managers for file reveal#671
Open
yasinkaraaslan wants to merge 1 commit into
Open
Windows: Use native Shell API to support third-party file managers for file reveal#671yasinkaraaslan wants to merge 1 commit into
yasinkaraaslan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation hardcodes explorer.exe when opening or revealing files. This is a bit of a pain for anyone using custom file managers (like Filepilot or Directory Opus), since it completely bypasses their default OS settings and forces standard Windows Explorer to open.
This PR fixes that by switching to the native Windows Shell APIs:
We now use ShellExecuteW for standard folder opening.
We use SHOpenFolderAndSelectItems when we specifically need to highlight or reveal a file.
(Also, Windows API handles both '/' and '\' internally for these shell calls so I removed a call to path_overwrite_seperators)