Conversation
market_price関連機能の削除、application/service層をドメインのAccountへ集約(OpenAccount/AddFunds/Rebalance/Total)、拠出表現を新規注文・追加注文へ統一、domain各typeへの説明コメント付与。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
tsx を直接使う構成では .js 拡張子は不要なため、 moduleResolution を Bundler から node に変更し、 全相対インポートの .js を削除した。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stockを{Symbol, Qty}から
{Symbol, AmountJpy}へ変更し、株数・市場価格を扱わず金額で直接保有するモデルに統一
AssetService/PortfolioServiceを削除し、Account.Total()/OpenAccount()/AddFunds()/Rebalance()としてドメインモデルに集約「拠出（contribution）」を「注文（order）」に全廃（usecase /
controller / request / error すべてリネーム）
EvaluationAmount→AmountJpyはパス、asset3 のリバランスは意図的に FAIL する初期状態を維持）
対象言語: golang / java8 / java17 / php / python / ruby / scala /
typescript（8言語すべて）