fix(picker.util): require trailing slash when matching git root in truncpath#2877
Open
madmaxieee wants to merge 1 commit into
Open
fix(picker.util): require trailing slash when matching git root in truncpath#2877madmaxieee wants to merge 1 commit into
madmaxieee wants to merge 1 commit into
Conversation
…uncpath When `git.get_root` returns "." (e.g. inside a git repo with a relative path), the old `path:find(root, 1, true)` would match the leading dot of dotfiles like ".stylua.toml", replacing it with the root tail and producing "./tylua.toml". By matching `root .. "/"` instead of bare `root`, we ensure the root is only matched as a directory prefix, so dotfiles and other paths starting with "." are left intact.
github-actions
Bot
added
size/xs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Snacks.git.get_root() returns "." (e.g. when inside a git repo using a relative path), the truncpath function's root-matching logic used
path:find(root, 1, true) == 1. This bare match on "." would also match the leading dot of dotfiles like .stylua.toml, causing the root-replacement logic to consume the dot and produce corrupted paths, e.g. .stylua.toml → ./tylua.toml.The character after the dot was consumed as part of the root match by
path:sub(#root + 2).Changed the match from
path:find(root, 1, true)topath:find(root .. "/", 1, true), requiring a trailing / after the root. This ensures the root is only matched as a directory prefix, so dotfiles and other paths starting with . are left intact. The slash after "." is assumed and removed anyways (the +2 part), so it's semantically the same.