-
Notifications
You must be signed in to change notification settings - Fork 16
[AISOS-2293] Implement external reference links for agent workflow context #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
forgeSmith-bot
wants to merge
12
commits into
forge-sdlc:main
Choose a base branch
from
forgeSmith-bot:forge/aisos-2293
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2df3f15
[AISOS-2293] Implement external reference links for agent workflow co…
14bb71c
[AISOS-2293] Execute task takeover changes for AISOS-2293
b74f030
[AISOS-2293] Add automated tests for mock comment sorting and non-lis…
b28943a
[AISOS-2293-ci-fix] Apply CI fix plan to references utility
3e7cad2
[AISOS-2293-review-ci-fix-1] Resolve Mypy type-checking issues and fo…
b600600
[AISOS-2293-ci-fix] Apply CI fix plan (attempt 2)
d0a1e41
[AISOS-2293-review-ci-fix-2] Post-ci-fix-2 code review
2ef4293
[AISOS-2293-ci-fix] Format fetch_and_inject_references function signa…
e8f5116
[AISOS-2293-review-fix] Implement PR review plan for AISOS-2293 / rev…
316b26d
[AISOS-2293] review: address PR feedback
f746b86
[AISOS-2293-review-review-impl] Hardened external reference handling …
61ee583
[AISOS-2293-review-review-impl] Post-review-impl code review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Arg name is overly generic
--descriptionas a top-levelproject-setupargument could collide with future options.--ref-descriptionwould be more specific and self-documenting about its pairing with--add-reference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forge implemented this feedback in the latest pushed revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forge verified this feedback; no additional code change was needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The top-level setup argument has been renamed to --ref-description as suggested, with --description retained as a deprecated alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The top-level setup argument has been renamed to --ref-description as suggested, with --description retained as a deprecated alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The top-level setup argument has been renamed to --ref-description as suggested, with --description retained as a deprecated alias, which is already fully implemented and verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The top-level setup argument has been renamed to --ref-description as suggested, with --description retained as a deprecated alias, which is already fully implemented and verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The top-level setup argument has been renamed to --ref-description as suggested, with --description retained as a deprecated alias, which is already fully implemented and verified.