[injector] Unfold rules at the recursive end of the rule#99
Merged
Conversation
To optimize depth calculation, unfolding of recursive rules should only
be done at the recursive end of the rule i.e., in a graph with:
```
A -> B -> C -> A
```
Unfolding to k-depth should yield:
```
A_k := B_k
B_k := C_k
C_k := A_{k - 1}
```
This is acheived using a sort of topological sort on recursive rules to
obtain an order to break up loops.
filipeom
force-pushed
the
filipe/fix-rules-unfolding
branch
from
e39089f to
4cd9108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To optimize depth calculation, unfolding of recursive rules should only be done at the recursive end of the rule i.e., in a graph with:
Unfolding to k-depth should yield:
This is acheived using a sort of topological sort on recursive rules to obtain an order to break up loops.