chore: replace benthos with redpanda/connect

[sylr]

No description provided.

[coderabbitai]

Walkthrough

The PR changes Benthos image resolution to Docker Hub’s Redpanda Connect image, updates the deployment image tag to 4.93.0, and changes the container command from /benthos to /redpanda-connect.

Changes

Benthos Image Update

Layer / File(s)	Summary
Image registry source update internal/resources/registries/image.go	GetBenthosImage now returns docker.io/redpandadata/connect:<version> with normalized versions, and its accepted-format documentation is generalized.
Deployment image and entrypoint update internal/resources/benthos/controller.go	createDeployment requests tag 4.93.0 and runs /redpanda-connect instead of /benthos.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: flemzord

Poem

A rabbit hops where containers connect,
A fresh image arrives, neatly checked.
The tag springs forward, commands take flight,
Redpanda Connect runs just right. 🐇

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No author description was provided, so relevance to the changeset can't be assessed.	Add a short description of the Benthos-to-Redpanda Connect image and command changes.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: replacing Benthos with Redpanda Connect.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/upgrade-benthos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

internal/resources/registries/image.go (1)

14-14: ⚡ Quick win

Update documentation to reflect the actual registry pattern.

The documentation comment still references jeffail/, but the actual GetBenthosImage implementation now uses docker.redpanda.com/redpandadata/connect. Consider updating this line to reflect the new pattern or removing the outdated reference.

📝 Suggested documentation fix

-// public.ecr.aws/<organization>/jeffail/
+// docker.redpanda.com/<organization>/<repository>:<version>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/resources/registries/image.go` at line 14, The file-level doc
comment is out of date: replace or remove the stale registry reference "//
public.ecr.aws/<organization>/jeffail/" so it matches the actual image registry
used by GetBenthosImage (docker.redpanda.com/redpandadata/connect) — update the
comment to the new pattern or delete the line entirely to avoid misleading docs;
ensure the comment near GetBenthosImage clearly shows the current registry
pattern "docker.redpanda.com/redpandadata/connect".

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@internal/resources/registries/image.go`:
- Line 14: The file-level doc comment is out of date: replace or remove the
stale registry reference "// public.ecr.aws/<organization>/jeffail/" so it
matches the actual image registry used by GetBenthosImage
(docker.redpanda.com/redpandadata/connect) — update the comment to the new
pattern or delete the line entirely to avoid misleading docs; ensure the comment
near GetBenthosImage clearly shows the current registry pattern
"docker.redpanda.com/redpandadata/connect".

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca3d6124-d569-4d97-81f8-49b3f1dcf3d1

📥 Commits

Reviewing files that changed from the base of the PR and between 6ec3a86 and 8f0403d.

📒 Files selected for processing (2)

• internal/resources/benthos/controller.go
• internal/resources/registries/image.go

[flemzord]

The comment does not match the line below.

[coderabbitai]

♻️ Duplicate comments (1)

internal/resources/registries/image.go (1)

14-14: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the incomplete registry format example.

Line 14 currently omits repository and version, so it no longer matches the accepted registry/image:<version> format documented around it.

Proposed fix

-// public.ecr.aws/<organization>/jeffail/
+// public.ecr.aws/<organization>/jeffail/benthos:<version>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/resources/registries/image.go` at line 14, The example registry
string "public.ecr.aws/<organization>/jeffail/" is incomplete and should follow
the documented registry/image:<version> format; update the comment to include a
repository and tag (for example replace "public.ecr.aws/<organization>/jeffail/"
with "public.ecr.aws/<organization>/jeffail/<image>:<version>") so the example
in internal/resources/registries/image.go matches the accepted format.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@internal/resources/registries/image.go`:
- Line 14: The example registry string "public.ecr.aws/<organization>/jeffail/"
is incomplete and should follow the documented registry/image:<version> format;
update the comment to include a repository and tag (for example replace
"public.ecr.aws/<organization>/jeffail/" with
"public.ecr.aws/<organization>/jeffail/<image>:<version>") so the example in
internal/resources/registries/image.go matches the accepted format.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e778195e-3bdf-492c-b710-4f1886d67831

📥 Commits

Reviewing files that changed from the base of the PR and between 8f0403d and bc3f1ca.

⛔ Files ignored due to path filters (1)

• tests/e2e/chainsaw/23-benthos-module/chainsaw-test.yaml is excluded by !**/*.yaml

📒 Files selected for processing (2)

• internal/resources/benthos/controller.go
• internal/resources/registries/image.go

[NumaryBot]

✅ Approve — automated review

This PR replaces the Benthos image reference with the Redpanda Connect equivalent. The previously identified issues — unqualified Docker Hub image reference, mismatched e2e test assertion, and stale comment in image.go — were all raised in prior automated and human review threads and appear to have been resolved in the current diff (the image is now fully qualified as docker.io/redpandadata/connect, the e2e assertion has been updated, and the comment corrected). The independent reviewer found no remaining correctness issues in the patch. No new findings warranting a change request were identified.

No findings.

[NumaryBot]

NumaryBot posted 2 new inline findings.

Summary: #463 (comment)

[NumaryBot]

NumaryBot posted 1 new inline finding.

Summary: #463 (comment)

[NumaryBot]

NumaryBot review complete: no remaining inline findings.

Resolved 1 stale NumaryBot review thread (0 fixed, 1 outdated).

Summary: #463 (comment)