Refactor Renovate configuration for clarity#566
Conversation
Added schedule for npn Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the Renovate configuration for readability by collapsing several multi-line arrays into single-line arrays, and it also adjusts npm-related package rules.
Changes:
- Reformat Renovate config arrays to be more compact (e.g.,
labels,ignoreDeps,matchManagers,schedule). - Add scheduling (and an extra label) to the Angular/TypeScript npm grouping rule.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
Maybe this should look a little more like https://github.com/frankframework/frankframework/blob/master/.github/renovate.json in terms of grouping and scheduling
Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
|
If it's almost the same as FF! than it should be good. |
| ] | ||
| "before 6am on monday" | ||
| ], | ||
| "minimumReleaseAge": "5 days" |
There was a problem hiding this comment.
Why did you choose 5 days?
Maybe 1 day is good too? Gives a bit of wiggle room, but pretty fast.
There was a problem hiding this comment.
Because this is done in the FF renovate version as well.
There was a problem hiding this comment.
Wait where do you see it? Could you send a permalink?
There was a problem hiding this comment.
There was a problem hiding this comment.
I mend a permalink to the specific like, I still can't find it.
There was a problem hiding this comment.
https://github.com/frankframework/frankframework/blob/master/.github/renovate.json#L70
https://github.com/frankframework/frankframework/blob/master/.github/renovate.json#L160
https://github.com/frankframework/frankframework/blob/master/.github/renovate.json#L174
https://github.com/frankframework/frankframework/blob/master/.github/renovate.json#L185
There was a problem hiding this comment.
Oh the selection above doesn't provide enough context. This is for the Frank!Framework packages, why should we wait 5 days for our own packages? Is there a supply chain security risk for something that is being build on the same servers as this application? I don't think so, we might remove the delay all together.
Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
Signed-off-by: Sergi Philipsen <philipsen.sergi@gmail.com>
|
Now everything is more uniform with the frankframework renovate.json
also no vulnerabilities anymore