fix: skip the hostname page when the installer already set one#26
Merged
Conversation
The bootc-installer wizard seeds and applies a hostname at install time, so first setup asked for it a second time. Snow images ship no /etc/hostname, so an untouched system reports the kernel/systemd fallback — only show the hostname page when the current hostname is one of those defaults (localhost, debian, empty). When the page is skipped in the non-OEM flow, the user page takes over the no-back-button role it inherited. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new bootc-installer flow prompts for a hostname (disk step, seeded with a hardware-derived default) and applies it at install time — then first setup asked again. Per tonight's decision, the installer owns the hostname; first setup now only asks when the system still has a never-customized hostname.
Change
backend.hostname_is_default(): true only for the never-customized fallbacks (localhost,localhost.localdomain,debian,(none), empty) — snow images ship no/etc/hostname, so an untouched system always reports one of these.window.py: the hostname page is only built/appended when that returns true (both OEM and standard flows). When skipped in the standard flow, the user page inheritsno_back_buttonso back-navigation into the connectivity check stays blocked.This stays adaptive: nbc-era installs, manual installs, or anything else that leaves
localhoststill gets the hostname page.Verification
Gate exercised directly (
localhost→ ask, installer-style hostname → skip),py_compileclean, no dangling__view_hostnamereferences, meson test run locally.🤖 Generated with Claude Code