fix(wp-cli): route @alias SSH commands to the vendored wp-cli#438
Open
oxyc wants to merge 7 commits into
Open
Conversation
wp-phpunit's abstract-testcase calls PHPUnit\Util\Test::parseTestMethodAnnotations(), removed in PHPUnit 10, so the open-ended ">=9.0" constraint resolving to PHPUnit 12 broke `composer phpunit`. Pin to >=9.0 <10 (matches the working stack on other Genero sites). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardises
config/wp-cli/pre-ssh.phpsowp @aliasSSH commands route to the vendored wp-cli on the remote instead of falling back to a global, outdated one.Two bugs this addresses (your repo had at least one):
Symfony\\Component\\Yaml\\Yaml+class_exists()variant is silently skipped in the wp-cli runtime (the class isn't autoloadable there), so<release>/vendor/binis never prepended to the remote$PATH.$runner->aliaswithout its leading@(productionvs@production), so the alias lookup inwp-cli.ymlmisses and the hook bails before exportingWP_CLI_SSH_PRE_CMD.When the vendored path is dropped, the remote uses a global wp-cli whose bundled
symfony/consoleclashes with Acorn'silluminate/consolev13:The fix uses wp-cli's bundled
Spycparser and normalises the alias key, so it works on old and new wp-cli. Verified in generoi/suomentyokalu#409.🤖 Generated with Claude Code